fargOCA issueshttps://gitlab.oca.eu/DISC/fargOCA/-/issues2023-03-23T00:34:43Zhttps://gitlab.oca.eu/DISC/fargOCA/-/issues/723Coord reorg2023-03-23T00:34:43ZAlain O' MiniussiCoord reorgRight now, we treat local and global coords indépendant, while it would be more convenient to express the hierarchy between local and global coords.Right now, we treat local and global coords indépendant, while it would be more convenient to express the hierarchy between local and global coords.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/722Persist computed fields2023-03-17T14:57:55ZAlain O' MiniussiPersist computed fieldsWhen python binding are not convenient (probably most of the time...) we still need to look at computed fields.
So we'd like to have a tool to persist them on disk.When python binding are not convenient (probably most of the time...) we still need to look at computed fields.
So we'd like to have a tool to persist them on disk.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/721Lets look at a gitlab test regression2023-12-14T12:20:45ZAlain O' MiniussiLets look at a gitlab test regressionHi @elena I'm going to look at the regression issue raised in 8fe805d005c210013a8861d293e9103790b9bbb0 and track the process here for future reference.
CheersHi @elena I'm going to look at the regression issue raised in 8fe805d005c210013a8861d293e9103790b9bbb0 and track the process here for future reference.
CheersElena LegaElena Legahttps://gitlab.oca.eu/DISC/fargOCA/-/issues/720seq_disk_load_config does not seem to work2023-03-28T22:15:58ZGabriele Pichierriseq_disk_load_config does not seem to workHello,
I noticed that `seq_disk_load_config` does not update the `nb_steps` field. I modified the config.info file to increase `NbStep` (for this specific case from 30000 to 30010) and then run the `utils/seq_disk_load_config disk30000....Hello,
I noticed that `seq_disk_load_config` does not update the `nb_steps` field. I modified the config.info file to increase `NbStep` (for this specific case from 30000 to 30010) and then run the `utils/seq_disk_load_config disk30000.h5 ./config.info` command as usual, but I get
```
$ h5dump -a /nb_steps disk30000.h5-bak
HDF5 "disk30000.h5-bak" {
ATTRIBUTE "nb_steps" {
DATATYPE H5T_STD_I32LE
DATASPACE SCALAR
DATA {
(0): 30000
}
}
}
$ h5dump -a /nb_steps disk30000.h5
HDF5 "disk30000.h5" {
ATTRIBUTE "nb_steps" {
DATATYPE H5T_STD_I32LE
DATASPACE SCALAR
DATA {
(0): 30000
}
}
}
```
and indeed re-launching fargOCA does not run the additional 10 steps as intended.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/719AdAstra GPU test run2023-06-29T13:22:08ZAlain O' MiniussiAdAstra GPU test runWe build on AdAstra, but not all the tests are "PASS"We build on AdAstra, but not all the tests are "PASS"Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/718extract_surf_dens outputs zeros2023-03-21T11:36:53ZGabriele Pichierriextract_surf_dens outputs zerosI'm running `utils/seq_extract_radial_surf_dens` on several discs (such as [this one](/uploads/c65fb404c80facd607210d2fdf21fdd9/config.info)) and I only get `0.0000000000000000e+00` as an output. This happens working on the most recent c...I'm running `utils/seq_extract_radial_surf_dens` on several discs (such as [this one](/uploads/c65fb404c80facd607210d2fdf21fdd9/config.info)) and I only get `0.0000000000000000e+00` as an output. This happens working on the most recent commit (043684ea), on different clusters.
This does not happen for the same exact setup for example using commit edd9f86d, which is the one I was using on my old clusters at MPIA).Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/716Not logarithme spacing test in example2023-03-15T10:05:23ZAlain O' MiniussiNot logarithme spacing test in example@elena
As shown in
```
23:30:00 [alainm@pollux fargOCA]# find examples/ -name "config.*.in" -exec grep -i spacing {} \;
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing A...@elena
As shown in
```
23:30:00 [alainm@pollux fargOCA]# find examples/ -name "config.*.in" -exec grep -i spacing {} \;
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
Spacing ARITHMETIC
23:30:05 [alainm@pollux fargOCA]#
```
We have no example using logarithmic spacing. Meaning we have no clue if it works or if the work done in 701 is actually relevant.
We should introduce a test or remove the feature. Right now the merging of 701 (which should arrive soon) could break the feature.Elena LegaElena Legahttps://gitlab.oca.eu/DISC/fargOCA/-/issues/715templatizecode on GridCoords2023-03-06T16:07:13ZAlain O' Miniussitemplatizecode on GridCoordsThis is necessary to handle efficiently different types of radial spacingThis is necessary to handle efficiently different types of radial spacingAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/714remove radial explicit coords2023-03-06T21:53:44ZAlain O' Miniussiremove radial explicit coordsAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/713remove phi coords2023-03-07T17:16:32ZAlain O' Miniussiremove phi coordsAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/712Remove theta coords2023-03-07T17:16:31ZAlain O' MiniussiRemove theta coordsThese can be computed on the flyThese can be computed on the flyAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/711Keep track of grid spacing2023-03-07T17:16:30ZAlain O' MiniussiKeep track of grid spacingIt will be needed if we drop explicit gridIt will be needed if we drop explicit gridAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/708Make GridCoords gas shape aware2023-03-07T17:16:29ZAlain O' MiniussiMake GridCoords gas shape awareThe GridCoord gas must know the grid boundaries if we want to use implicit gridsThe GridCoord gas must know the grid boundaries if we want to use implicit gridsAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/707Remove the FILE coordinate type2023-03-07T17:16:28ZAlain O' MiniussiRemove the FILE coordinate typeThere is not point in storing coordinates on disk when using implicit gridsThere is not point in storing coordinates on disk when using implicit gridsAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/705Gustavo's project2023-11-21T16:10:46ZElena LegaGustavo's projectIn this issue we address some questions about the project that Gustavo has just startedIn this issue we address some questions about the project that Gustavo has just startedElena LegaElena Legahttps://gitlab.oca.eu/DISC/fargOCA/-/issues/704MacOS build2023-02-21T11:55:22ZAlain O' MiniussiMacOS buildReported by @madeira.
We have no Apple computer to test the issue directly. But that does not prevent us from investigating.
@elena @crida you might be interested in this issue.Reported by @madeira.
We have no Apple computer to test the issue directly. But that does not prevent us from investigating.
@elena @crida you might be interested in this issue.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/703Templatize grid2023-02-07T10:00:48ZAlain O' MiniussiTemplatize gridGrid can be implemented in different ways, and we're not sure which one is better right now.
So we'll allow a few of them.Grid can be implemented in different ways, and we're not sure which one is better right now.
So we'll allow a few of them.Viscosity ReorganisationAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/702Use half as medium2023-02-21T14:33:13ZAlain O' MiniussiUse half as mediumRight now, the medium coordinate in the radial direction is barycentric, which is not very usefull and complexify the code.Right now, the medium coordinate in the radial direction is barycentric, which is not very usefull and complexify the code.https://gitlab.oca.eu/DISC/fargOCA/-/issues/701Remove explicit non uniform grid2023-03-07T17:16:28ZAlain O' MiniussiRemove explicit non uniform gridWe don[t use those anymore. And right now they're in the way of optimisations, multi grid etc..We don[t use those anymore. And right now they're in the way of optimisations, multi grid etc..Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/700Introduce dust as pressureless fluid2023-03-15T15:53:22ZElena LegaIntroduce dust as pressureless fluidIn order to add more physics to the fargOCA code, and in line with Philippine's thesis actual project, the idea is to
introduce dust populations that are treated as a pressureless fluid following the prescription that is in Fargo3D
Ano...In order to add more physics to the fargOCA code, and in line with Philippine's thesis actual project, the idea is to
introduce dust populations that are treated as a pressureless fluid following the prescription that is in Fargo3D
Another possibility is to treat dust as particles, this requires the use of the Symba integratore that is already at disposal in fargOCA,
what needs to be added is the drag force acting on particles due to gas. May be this second approach is more straightforward.Add dustElena LegaElena Lega