fargOCA issueshttps://gitlab.oca.eu/DISC/fargOCA/-/issues2024-03-27T22:12:45Zhttps://gitlab.oca.eu/DISC/fargOCA/-/issues/765refactor diffusion coeff. computing2024-03-27T22:12:45ZAlain O' Miniussirefactor diffusion coeff. computingRigth now, it's dispatched over many kernel. This is both confusing and inefficient (although not a bottleneck).Rigth now, it's dispatched over many kernel. This is both confusing and inefficient (although not a bottleneck).Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/764moving from boost::random to std::random2024-03-22T17:29:28ZAlain O' Miniussimoving from boost::random to std::randomAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/763fpe with WIND star accretion type2024-03-21T15:16:33ZAlain O' Miniussifpe with WIND star accretion type@elena
In that mode, the radial speed is initialized with:
```
vradial(i,h,j) = -(2*torqueCoeff/(1
+exp(-steepness*(1
...@elena
In that mode, the radial speed is initialized with:
```
vradial(i,h,j) = -(2*torqueCoeff/(1
+exp(-steepness*(1
-dead(i,h,j)
/userActiveDensity)))
/radii(i));});
```
But `dead(i,h,j)` can have significantly big values (>150) with `-steepness*(1-dead(i,h,j)/userActiveDensity)` reaching 839.119345 which is too big for an exponential.Elena LegaElena Legahttps://gitlab.oca.eu/DISC/fargOCA/-/issues/762Planets with mass 02024-03-21T08:05:45ZAlain O' MiniussiPlanets with mass 0It seems that we authorize planets with mass 0 (ex: 3D_radiative_restart). As a result, their roche limit is also 0.
But in hillForce.cpp:116 we have:
```
=> real const ...It seems that we authorize planets with mass 0 (ex: 3D_radiative_restart). As a result, their roche limit is also 0.
But in hillForce.cpp:116 we have:
```
=> real const hillCut = 1/(exp(-(dist2Cell-0.8*rh)/(0.08*rh))+1);
```
which results in a divide by 0.
How should we deal with that ? prohibit 0 mass planet seems to be the way to go ?Elena LegaElena Legahttps://gitlab.oca.eu/DISC/fargOCA/-/issues/761Accretion time inverse error checking2024-03-20T10:27:42ZAlain O' MiniussiAccretion time inverse error checkingRight now, we tolerate _AccretionTimeInverse_ with 0 value, which does not make much sense (and trigger divide by zero).
We should ensure that _AccretionTimeInverse_ and _AccretionTime_, if specified, are strictly > 0, that boths are n...Right now, we tolerate _AccretionTimeInverse_ with 0 value, which does not make much sense (and trigger divide by zero).
We should ensure that _AccretionTimeInverse_ and _AccretionTime_, if specified, are strictly > 0, that boths are not specified at the same time, and maybe drop _AccretionTimeInverse_.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/760adastra testing framework2024-03-07T14:34:41ZAlain O' Miniussiadastra testing frameworkWe have tons of testing issues on this one due to slurm configuration specificity.
It could impact other platformsWe have tons of testing issues on this one due to slurm configuration specificity.
It could impact other platformsAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/758Remove CUDA specific hacks2024-03-07T15:07:44ZAlain O' MiniussiRemove CUDA specific hacksWe introduced artificial intermediate function to accommodate CUDA limitations. One of them that kernel could not be declared in ctors and/or private function (?).
This might not be the case anymore.So maybe we can simplify things.We introduced artificial intermediate function to accommodate CUDA limitations. One of them that kernel could not be declared in ctors and/or private function (?).
This might not be the case anymore.So maybe we can simplify things.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/757Modularize diffusion solver2024-02-28T12:04:21ZAlain O' MiniussiModularize diffusion solverIn order to be able to use different solvers, we want to clearly separate the matrix assembly from the solver part.In order to be able to use different solvers, we want to clearly separate the matrix assembly from the solver part.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/756Do not build sequential when asked for parallel2024-02-12T22:59:26ZAlain O' MiniussiDo not build sequential when asked for parallelRight now we build the sequential version of the code even when asking for parallel version.
This was justified to allow the use for utilities when on the login nodes of cluster that do not allow MPI run of one proc on the frontal.
But...Right now we build the sequential version of the code even when asking for parallel version.
This was justified to allow the use for utilities when on the login nodes of cluster that do not allow MPI run of one proc on the frontal.
But this has become a lot of trouble with the use of third party libraries and not that usefull with the rise of GPUs (that are not always available on login nodes either (at least, not the same GPU as the compute nodes).
It is more convenient to allow one kind of build per build directory and ask explicitly the kinds we need.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/755GPU direct detection2024-02-09T16:25:04ZAlain O' MiniussiGPU direct detectionThere is no standard way to check for direct GPU availability.
We need to rely on bits of knowledge available here and there.
A synthesis of these knowledge is proposed here: https://dci.dci-gitlab.cines.fr/webextranet/software_stack/l...There is no standard way to check for direct GPU availability.
We need to rely on bits of knowledge available here and there.
A synthesis of these knowledge is proposed here: https://dci.dci-gitlab.cines.fr/webextranet/software_stack/libraries/index.html#detecting-if-mpi-is-gpu-aware
We are going to import that.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/754Long tests on AdAstra2024-02-09T17:15:17ZAlain O' MiniussiLong tests on AdAstraWe have some tests that take weirdly long on adastra's gpu.
Let's nvestigate.We have some tests that take weirdly long on adastra's gpu.
Let's nvestigate.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/753remove all reference to C MPI interface when building in sequential mode2024-02-14T15:14:35ZAlain O' Miniussiremove all reference to C MPI interface when building in sequential modeRithg now, we use a dummy C MPI implementation to make our sequential Boost.MPI happy.
But that clashes with PETSc MPIUNI and is not a good long term solution.
This C in house empty C MPI API is probably not that mandatoryRithg now, we use a dummy C MPI implementation to make our sequential Boost.MPI happy.
But that clashes with PETSc MPIUNI and is not a good long term solution.
This C in house empty C MPI API is probably not that mandatoryAlain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/752port on AdAstra CCE-X-3.XY2024-02-09T19:11:33ZAlain O' Miniussiport on AdAstra CCE-X-3.XYThe fixed AdAstra environnement is out, let's try it.The fixed AdAstra environnement is out, let's try it.https://gitlab.oca.eu/DISC/fargOCA/-/issues/751PETSc or GinkGo integration2024-03-06T14:52:20ZAlain O' MiniussiPETSc or GinkGo integrationTry to see if we can integrate a PETSc or GinkGo solver.Try to see if we can integrate a PETSc or GinkGo solver.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/750Writing radial velocity component at time 02024-01-23T09:18:16ZElena LegaWriting radial velocity component at time 0Initial radial velocity seems to be 0Initial radial velocity seems to be 0Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/749Change the density slope in the cavity2024-01-23T08:08:34ZElena LegaChange the density slope in the cavityWe would like to have a more general prescription for density behaviour in the cavityWe would like to have a more general prescription for density behaviour in the cavityElena LegaElena Legahttps://gitlab.oca.eu/DISC/fargOCA/-/issues/748Stop reporting unused config2023-12-17T09:36:14ZAlain O' MiniussiStop reporting unused configthe feature is broken, and with now report usage of defaults values which is more useful anyway.the feature is broken, and with now report usage of defaults values which is more useful anyway.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/746Be minimalist in link spec2023-12-14T12:22:45ZAlain O' MiniussiBe minimalist in link specRight now, some libraries are specified everywhere.Right now, some libraries are specified everywhere.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/745Horus install2023-12-15T10:54:32ZAlain O' MiniussiHorus installWe need to install fargOCA dependencies on horus. So we might as well make it a script.We need to install fargOCA dependencies on horus. So we might as well make it a script.Alain O' MiniussiAlain O' Miniussihttps://gitlab.oca.eu/DISC/fargOCA/-/issues/744Cooling Spec2023-12-06T00:08:56ZAlain O' MiniussiCooling SpecWe would like to have at least two type of cooling, so a boolean is not enough.
To begin with, we wand Beta cooling (the current one) and Radiative Cooling.We would like to have at least two type of cooling, so a boolean is not enough.
To begin with, we wand Beta cooling (the current one) and Radiative Cooling.Alain O' MiniussiAlain O' Miniussi